Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exhaustive deps to social block edit effect #65738

Closed
wants to merge 1 commit into from

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Sep 30, 2024

What?

Closes #64896

Why?

Code quality.

How?

Adds missing deps. Removes ESLint exception.

Testing Instructions

N/A

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A

@draganescu draganescu added the [Type] Code Quality Issues or PRs that relate to code quality label Sep 30, 2024
@draganescu draganescu changed the title add exhaustive deps to social block edit effect Add exhaustive deps to social block edit effect Sep 30, 2024
@draganescu draganescu marked this pull request as ready for review September 30, 2024 10:54
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: draganescu <[email protected]>
Co-authored-by: getdave <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@getdave
Copy link
Contributor

getdave commented Sep 30, 2024

This is on your fork of the Plugin?

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the current functionality of reverting the icon background and text color. I believe it's because the else statement now runs as the deps change which causes the attributes to update to the "backup" which is empty.

We should probably populate the backgroundBackupRef each time the effect runs.

@draganescu
Copy link
Contributor Author

I am not sure what happened here that resulted in this PR opened agains WP trunk ... weird.

@draganescu draganescu closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
Development

Successfully merging this pull request may close these issues.

Fix effect deps in Social Links block
2 participants