Quick Edit: add Template field #66591
Draft
+941
−374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Press/gutenberg into add/template-form
gigitux
changed the base branch from
trunk
to
update/dataform_combined_fields_api
gigitux
changed the base branch from
update/dataform_combined_fields_api
to
trunk
gigitux
changed the title
|
Size Change: +789 B (+0.04%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
…Press/gutenberg into add/template-form
gigitux
changed the base branch from
trunk
to
update/dataform_combined_fields_api
|
Flaky tests detected in f31a91c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11702903863
|
louwie17
force-pushed
the
update/dataform_combined_fields_api
branch
from
5e91b52
to
ddf996a
Compare
|
I rebased this PR after the last changes on #66531 |
…Press/gutenberg into add/template-form
gigitux
force-pushed
the
add/template-form
branch
from
9d641f4
to
f31a91c
Compare
louwie17
force-pushed
the
update/dataform_combined_fields_api
branch
from
ddf996a
to
21f7f9e
Compare
louwie17
force-pushed
the
update/dataform_combined_fields_api
branch
from
21f7f9e
to
a39bd57
Compare
oandregal
force-pushed
the
update/dataform_combined_fields_api
branch
from
a39bd57
to
78f6ade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is based on top of #66531
This PR is part of #64519.
Why?
This PR adds the
Templatefield.Testing Instructions
Use default template.Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-10-30.at.20-10-04.mp4
Drawbacks
@wordpress/block-editordependencyTo implement the modal previewing all the templates is necessary use the
__experimentalBlockPatternsListfrom the@wordpress-block-editorpackage.Uncaught TypeError: Cannot destructure property 'avatarURL' of '(0 , _wordpress_data__WEBPACK_IMPORTED_MODULE_3__.useSelect)(...)' as it is undefinederrorIn some cases, the templates in the modal aren't rendered correctly due to this JavaScript error:
Screen.Capture.on.2024-10-30.at.20-15-04.mov
gutenberg/packages/block-library/src/avatar/hooks.js
Lines 19 to 26 in 61f9655
This happens when the setting object isn't initialized. To fix this issue, I pushed 5a623fb. Still, I'm not sure that this is the best solution 🤔.
It is a similar issue that I tried to tackle with #66459.
cc @oandregal @youknowriad and @louwie17