Skip to content

DimensionControl: Deprecate 36px default size#66705

Merged
mirka merged 4 commits intoWordPress:trunkfrom
hbhalodia:fix/issue-65751-deprecation-DimensionControl
Nov 15, 2024
Merged

DimensionControl: Deprecate 36px default size#66705
mirka merged 4 commits intoWordPress:trunkfrom
hbhalodia:fix/issue-65751-deprecation-DimensionControl

Conversation

@hbhalodia
Copy link
Contributor

Part of #65751

What?

Deprecate the 36px default size on DimensionControl.

Testing Instructions

  • Unit tests pass
  • Storybook stories should not log console warnings
  • All code snippets in documentation (JSDoc, Storybook, README) should have the __next40pxDefaultSize prop enabled

@hbhalodia hbhalodia requested a review from ajitbohra as a code owner November 4, 2024 04:19
@github-actions
Copy link

github-actions bot commented Nov 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team November 13, 2024 20:29
@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components Needs Dev Note Requires a developer note for a major WordPress release cycle labels Nov 13, 2024
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mirka mirka enabled auto-merge (squash) November 15, 2024 22:04
@mirka mirka merged commit 865a058 into WordPress:trunk Nov 15, 2024
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 15, 2024
@Mamaduka Mamaduka mentioned this pull request Mar 12, 2025
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants