Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug ] Fixed Spacer block, when used as Grow(Fill) or Fit, will prompt a user about unsaved changes #67045

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Mayank-Tripathi32
Copy link

Fixes #67041

What?

This pull request resolves #67041 by adding additional checks before updating attributes on page load. Specifically, it ensures that the width attribute is not reset to undefined if it is already undefined.

Why?

Currently, when a user reloads a page containing a Spacer Block set to "Fill" or "Grow," WordPress identifies unsaved changes, even when no edits were made. This can lead to confusion and disrupt the editing experience.

How?

This update introduces a condition in the useEffect hook to verify if width is already undefined. If so, the value remains unchanged. This prevents unnecessary updates that cause WordPress to flag the post as modified.

Testing Instructions

  1. Create a new post.
  2. Insert a Stack block.
  3. Add a Spacer block within the Stack.
  4. Set the Spacer to Grow.
  5. Publish the post.
  6. Navigate to the All Posts list.
  7. Reopen the post for editing.
  8. Make no changes and navigate away or reload.
    • Before the update: You would be prompted with a warning about unsaved changes.
    • After the update: No such prompt appears, confirming that attributes are not incorrectly updated.

Screenshots

NA

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: MadtownLems <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Mayank-Tripathi32! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 15, 2024
@Mayank-Tripathi32 Mayank-Tripathi32 changed the title Fixed Spacer block, when used as Grow(Fill) or Fit, will prompt a user about unsaved changes [Bug ] Fixed Spacer block, when used as Grow(Fill) or Fit, will prompt a user about unsaved changes Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
1 participant