Storybook: Add stories for AlignmentToolbar and AlignmentControl components #67046
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
miminari
added
Storybook
miminari
requested review from
mirka and
t-hamano
and removed request for
ellatrix
| @@ -0,0 +1,47 @@ | |||
| /** | |||
There was a problem hiding this comment.
Since almost all file names in gutenberg are hyphenated, aliginment-toolbar.story.js might be better.
| type: 'select', | ||
| options: [ 'undefined', 'left', 'center', 'right' ], |
There was a problem hiding this comment.
Why is the select type being used here? I'm not familiar with these parameters, but it doesn't seem to be reflected in Storybook at all 🤔
There was a problem hiding this comment.
Oh, Sorry. I forgot to erase what I wrote to try it out....
|
@t-hamano Thank you for quick reviewing! |
What?
This PR will add stories for AlignmentToolbar and AlignmentControl components in the Storybook
Why?
Most of Block Editor components don't have stories.
Block Editor components's Storybook should also be added and updated like the Components.
see #66519
related #22891
How?
I have referred to the TextAlignmentControl story.
AlignmentControl and AlignmentToolbar are based on same component, but there are deliberately generated as a component with a different name, so I created in two separate files.
Testing Instructions
npm run storybook:devand please check the AlignmentControl and AlignmentToolbar stories.Testing Instructions for Keyboard
Screenshots or screencast
Kapture.2024-11-16.at.13.37.50.mp4