SlotFill: fix dependencies of registration effects, deduplicate code #67071
+10
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
jsnajdr
requested review from
Mamaduka,
youknowriad,
mirka,
ciampo and
tyxla
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Nov 18, 2024
| @@ -11,7 +11,7 @@ import useSlot from './use-slot'; | |||
| import type { FillComponentProps } from './types'; | |||
|
|
|||
| export default function Fill( { name, children }: FillComponentProps ) { | |||
| const { registerFill, unregisterFill } = useContext( SlotFillContext ); | |||
| const registry = useContext( SlotFillContext ); | |||
There was a problem hiding this comment.
Is this a stable value?
There was a problem hiding this comment.
Yes, as long as the context provider is the same, the registry is a constant object.
youknowriad
approved these changes
Nov 18, 2024
jsnajdr
force-pushed
the
update/slot-fill-effects
branch
from
23864f6
to
52f0c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tidies up the code for a
Fillregistration and rendering.For registration and unregistration, there used to be two effects: one runs on mount/unmount, another on
namechange. They can be easily merged into one with a[ name ]dependency. Registration and unregistration still happens at exactly the right times. And also theref.current.namevalue is updated whennamechanges.There's also a second effect that updates
ref.current.childrenand rerenders the slot whenchildrenchange. This one needs additionalslotdependency. Theslotobject is constant the entire time a slot is mounted.