ColorPicker: Add accessible label for copy button #67094
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Nov 18, 2024
| @@ -65,6 +65,11 @@ export const ColorCopyButton = ( props: ColorCopyButtonProps ) => { | |||
| > | |||
| <CopyButton | |||
| size="small" | |||
| aria-label={ | |||
There was a problem hiding this comment.
This shouldn't result in a redundant ARIA description, thanks to #65989.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #57168
Addresses ##57157 (maybe not a full fix)
What?
Adds an accessible label for the copy button in ColorPicker.
Why?
The icon button was only associated with an ARIA description via the Tooltip, and didn't have an ARIA label. This is a pretty big bug which fix was stalled in #57168, so I'm proposing we address this now in a less controversial way.
Testing Instructions for Keyboard
See the Storybook story for ColorPicker and check that the copy button is accessibly labeled.