Adding page state in data view #67609
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Enhancement
| 'checkoutPageId' => get_option( 'woocommerce_checkout_page_id' ), | ||
| 'accountPageId' => get_option( 'woocommerce_myaccount_page_id' ), | ||
| 'shopPageId' => get_option( 'woocommerce_shop_page_id' ), | ||
| ); |
There was a problem hiding this comment.
Neither Gutenberg or core should add support for specific plugins.
To support the display_post_states filter added in any theme or plugin, we need to find a way to use the filter with the rest API.
There was a problem hiding this comment.
Hi @carolinan,
Thank you for your review and feedback!
I've made the necessary modifications based on your suggestions. Could you please take a look and let me know if I’m on the right track or if I’ve misunderstood anything?
Looking forward to your thoughts!
There was a problem hiding this comment.
Hi
I expected the code related to other plugins like WooCommerce to be completely removed.
My knowledge of the rest API is not advanced enough to know if the action is suitable.
What?
Fixes #67517
Why?
Currently, page state is not showing in data view for Privacy policy and WooCommerce pages.
How?
Added page state label in data view or Privacy policy and WooCommerce pages.
Testing Instructions
Screenshots or screencast