Skip to content

Fix: Extra Space Between Caption and Embedded Content in Embed Block #68014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Rishit30G
Copy link
Contributor

@Rishit30G Rishit30G commented Dec 16, 2024

What?

This PR is intended to solve issue for spacing between the caption and spotify embed

Why?

Resolves #67859

How?

The PR adds two new variations to Embed Block specifically for Spotify Embeds

Testing Instructions

Testing Instructions for Keyboard

Log in to the WordPress dashboard and navigate to a post or page editor.
Add an Embed block (e.g., Spotify or Twitter).
Paste a valid URL to embed the content.
Add a caption below the embed by clicking the “Add caption” option.
Observe the extra space between the caption and the embedded content.
Now add the .wp-embed-aspect-5-3 or .wp-embed-aspect-5-2 in the Additional CSS section to fix the issue

Screenshots or screencast

Screen.Recording.2024-12-16.at.1.28.00.PM.mov

Copy link

github-actions bot commented Dec 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Rishit30G <[email protected]>
Co-authored-by: ellatrix <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ellatrix
Copy link
Member

Why not remove the aspect ratio for Spotify embeds?

@Rishit30G
Copy link
Contributor Author

@ellatrix, Thanks for the suggestion
We can definitely do that, but I think there are different sizes in which we can show the spotify embed, so by adding aspect ratio variations we are basically giving users the flexibility to select their choice of view for the embed without compromising on extra space below it
Sharing a screenshot of the different ways in which we can show the spotify embed:

image image

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Embed Affects the Embed Block labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra Space Between Caption and Embedded Content in Embed Block
3 participants