Skip to content

Handle label fallback for dropdownMenu #70951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Handle label fallback for dropdownMenu #70951

wants to merge 2 commits into from
+4 −1

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Jul 29, 2025 •
edited
Loading

Closes: #70949

What?

Omitted label prop from the dropdownMenuProps used inside ToolsPanelHeaderProps

@im3dabasia im3dabasia changed the title [WIP]: Handle label fallback for dropdownMenu Handle label fallback for dropdownMenu Jul 30, 2025
@im3dabasia im3dabasia marked this pull request as ready for review July 30, 2025 05:57
@im3dabasia im3dabasia requested a review from ajitbohra as a code owner July 30, 2025 05:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Jul 31, 2025
@t-hamano
Copy link
Contributor

@im3dabasia Thanks for the PR!

Can you update this PR according to this comment?

@t-hamano t-hamano requested a review from a team July 31, 2025 01:01
t-hamano
t-hamano reviewed Aug 6, 2025
View reviewed changes
packages/components/src/tools-panel/types.ts
Comment on lines -80 to +83
dropdownMenuProps?: React.ComponentProps< typeof DropdownMenu >;
dropdownMenuProps?: Omit<
React.ComponentProps< typeof DropdownMenu >,
'label'
>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this format is correct, but I don't know how to describe it in the README 😅

gutenberg/packages/components/src/tools-panel/tools-panel-header/README.md

Line 25 in 53b643c

- Type: `DropdownMenuProps`

cc @WordPress/gutenberg-components

Additionally, I think we need to update here as well:

gutenberg/packages/components/src/tools-panel/types.ts

Line 23 in 53b643c

dropdownMenuProps?: React.ComponentProps< typeof DropdownMenu >;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to describe it in the README 😅

Mm, I'm fine with this for now, it's not crucial information. And we won't have to think about this once these are converted to an autogenerated readme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka mirka left review comments

@t-hamano t-hamano t-hamano left review comments

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ToolsPanel: dropdownMenuProps type requires unnecessary label property
3 participants
@im3dabasia @t-hamano @mirka