Skip to content

FormTokenField: Improve use case stories #71121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

mirka
Copy link
Member

@mirka mirka commented Aug 7, 2025

What?

Improves the stories for FormTokenField so the solutions to common use cases are easier to discover.

Why?

  • The displayTransform prop was not covered in the custom render story.
  • It was slightly unclear that the With Validated Input story was demonstrating how you can disallow a user from adding new tokens.

Testing Instructions

npm run storybook:dev and see the stories for FormTokenField.

@mirka mirka self-assigned this Aug 7, 2025
@mirka mirka added the [Type] Developer Documentation Documentation for developers label Aug 7, 2025
@mirka mirka requested a review from ajitbohra as a code owner August 7, 2025 15:59
@mirka mirka added [Package] Components /packages/components Storybook Storybook and its stories for components labels Aug 7, 2025
Copy link

github-actions bot commented Aug 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @elazzabi.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: elazzabi.

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested review from aduth and a team August 7, 2025 15:59
Copy link
Contributor

@elazzabi elazzabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Thank you for making it easier for us 🙏

Copy link

github-actions bot commented Aug 7, 2025

Flaky tests detected in 9385ca5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16809563734
📝 Reported issues:

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tyxla tyxla merged commit bb9aa5a into trunk Aug 7, 2025
80 checks passed
@tyxla tyxla deleted the improve-form-token-field-examples branch August 7, 2025 20:03
@github-actions github-actions bot added this to the Gutenberg 21.5 milestone Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants