-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Storybook: Move validated form components into main grouping #71181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -16,8 +16,8 @@ import { formDecorator } from './story-utils'; | |||
import type { ControlWithError } from '../../control-with-error'; | |||
|
|||
const meta: Meta< typeof ControlWithError > = { | |||
title: 'Components (Experimental)/Validated Form Controls/Overview', | |||
tags: [ 'status-private' ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the tag here since this is not really a component.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: 0 B Total Size: 1.91 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
storybook/manager-head.html
Outdated
@@ -23,13 +23,29 @@ | |||
'treegrid', | |||
'truncate', | |||
'unitcontrol', | |||
'validatedcheckboxcontrol', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What effect do these lines have? I understand they're used below to create redirects from previously-experimental components, but did these URLs ever exist previously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's handled in the redirect block added below. But that doesn't explain what these lines do, unless I'm missing something.
gutenberg/storybook/manager-head.html
Lines 45 to 48 in 718a592
{ | |
from: /\/components-experimental-validated-form-controls-/, | |
to: '/components-', | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't that supposed to be the catch-all for the rest of the instances, like the overview ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aduth You're right 😱 That was redundant.
Flaky tests detected in 818ac14. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16947876554
|
Follow-up to #70540
Part of #66805
What?
Moves the validated form components into the main Components grouping in Storybook, completely removing the "Components (Experimental)" grouping.
Why?
For easier browsing of the component list.
Testing Instructions
npm run storybook:dev
Screenshots or screencast