-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Footnotes: Don't merge this - just a test #74275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ramonjd
wants to merge
6
commits into
trunk
Choose a base branch
from
try/migrate-footnotes-to-block
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and migrating footnotes from post meta. This update includes logic to manage footnotes in both block attributes and post meta for backward compatibility, ensuring a seamless transition for users. Additionally, the footnotes are now initialized correctly when creating new footnotes blocks.
…emoved redundant checks for footnote order and ensured attributes are always updated for correct numbering. This enhances the handling of footnotes in both block attributes and post meta.
|
Size Change: +736 B (+0.03%) Total Size: 2.59 MB
ℹ️ View Unchanged
|
…ntroduced a custom hook for managing footnotes from block attributes and post meta, ensuring backward compatibility. Enhanced rendering by escaping attributes and content for improved security.
…e logic. Introduced a new function to find footnotes blocks and updated existing functions to streamline the process of updating footnotes from both block attributes and post meta. This enhances the overall functionality and ensures correct numbering in rich text attributes.
…ect usage. Added checks to disallow footnotes within other footnotes blocks and prevent selection of footnotes blocks themselves. This improves the overall integrity of footnotes handling in the editor.
…ng undo scenarios. Refactor logic to always apply footnote numbering updates and force re-renders of blocks with footnotes. This improves the integrity of footnotes management in the editor and ensures accurate display after edits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Block library
/packages/block-library
[Package] Core data
/packages/core-data
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧
This PR is just to test some code. It's not to be merged. What are you even doing here, looking at it? Close your eyes! The horror!
🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧
What?
Converting footnotes content to block attributegs
Kapture.2025-12-31.at.13.23.59.mp4
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast