-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Latest Comments: Remove wrapper div and use HtmlRenderer for dynamic content rendering #74277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Latest Comments: Remove wrapper div and use HtmlRenderer for dynamic content rendering #74277
Conversation
…content rendering
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| const dropdownMenuProps = useToolsPanelDropdownMenuProps(); | ||
|
|
||
| const { content, status, error } = useServerSideRender( { | ||
| attributes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| attributes, | |
| attributes: serverSideAttributes, |
Should'nt be this? why to remove serverSideAttributes variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hbhalodia , I initially thought about removing the serverSideAttributes variable since HtmlRenderer merges both the server-rendered attributes and wrapperProps, and during my testing it didn't seem to cause any visual issues. I've reverted changes to keep serverSideAttributes.
What?
Part of Issue- #74248
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2025-12-30.at.4.16.25.PM.mov