@wordpress/theme: update colorjs.io to version 0.6.0
#74278
+53
−530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.11 kB (+0.04%) Total Size: 2.6 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
feat/update-colorjs
branch
from
d1d206a to
8c27650
Compare
ciampo
force-pushed
the
feat/update-colorjs
branch
from
8c27650 to
28f7cd8
Compare
ciampo
commented
Dec 30, 2025
Contributor
Author
There was a problem hiding this comment.
I double-checked (with some help from AI too) that the line removals about packages/babel-preset-default/node_modules/** are correct, as npm is deduping some unnecessary dependencies — this is because the root-level @babel/* packages (version 7.25.9) should now satisfy all the requirements, thus making the nested 7.25.7 versions unnecessary.
ciampo
force-pushed
the
feat/update-colorjs
branch
2 times, most recently
from
b4a5437 to
38a4e6c
Compare
ciampo
commented
Dec 30, 2025
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
commented
Dec 30, 2025
| const sStops = [ 100, 80, 60, 40, 20, 0 ]; | ||
| const hstops = [ 0, 60, 120, 180, 240, 300 ]; | ||
|
|
||
| describe.skip( 'buildRamps', () => { |
Contributor
Author
There was a problem hiding this comment.
Let's see if, by using colorjs.io's internal rounding, we can get the tests to pass in CI and therefore close #73726
Member
|
Reviewing the release notes around "More control over serialization", does this mean we could remove the
...plus a few more in color ramps tests. |
aduth
approved these changes
Dec 30, 2025
| // With 3 decimal places rounding to the nearest 0.001, the maximum rounding | ||
| // error is 0.0005. With 256 possible hex values, 0.0005 × 256 = 0.128, | ||
| // guaranteeing the rounded value stays within 0.5 of the original value. | ||
| const ROUNDING_PRECISION = 3; |
Member
There was a problem hiding this comment.
Nit: I saw some value in having the "hex" qualifier that we're dropping with these changes, as the file could foreseeably include some other rounding to disambiguate, and also that a rounding precision of 3 is not just some arbitrary value we want to apply to all rounding, but is specifically focused around this need for lossless hex serialization.
Member
|
When @jsnajdr originally proposed the version update, I also considered touching-up his other comment about redundant parses as part of the upgrade. Worth including? |
ciampo
force-pushed
the
feat/update-colorjs
branch
from
38a4e6c to
41ed638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #74281
What?
Update the
colorjs.iodependency in the@wordpress/themepackage to the latest released version0.6.0Why?
To benefit from the latest fixes and improvements https://github.com/color-js/color.js/releases/tag/v0.6.0
How?
[email protected]to match the CI environmentpackage.jsonfile for the@wordpress/themepackagenpm installto updatepackage-lock.jsonnullinstead ofNaNfor "none" valuesNumberobjectsTesting Instructions