Footnotes: prevent inserting footnotes within a footnotes block #74287
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
Size Change: +37 B (0%) Total Size: 2.59 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Dec 31, 2025
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
commented
Dec 31, 2025
SirLouen
reviewed
Dec 31, 2025
|
|
||
| const POST_CONTENT_BLOCK_NAME = 'core/post-content'; | ||
| const SYNCED_PATTERN_BLOCK_NAME = 'core/block'; | ||
| const FOOTNOTES_BLOCK_NAME = 'core/footnotes'; |
Member
There was a problem hiding this comment.
Wouldn't be a little cleaner to use?
import { name as FOOTNOTES_BLOCK_NAME } from './block.json';
Member
There was a problem hiding this comment.
Why? In this case, inline constants make more sense. IMO.
Member
There was a problem hiding this comment.
Generally looks good avoiding duplication of something hardcoded if it already exists
SirLouen
reviewed
Dec 31, 2025
Comment on lines
+89
to
+90
| getSelectionStart, | ||
| getBlockName: _getBlockName, |
Member
There was a problem hiding this comment.
Also I've noted, that instead of taking getSelectionStart you could take _getSelectedBlockClientId
getSelectedBlockClientId: _getSelectedBlockClientId,And then use it to get the selectedClientId
- const selectionStart = getSelectionStart();
+ const selectedClientId = _getSelectedBlockClientId();What do you think?
Member
There was a problem hiding this comment.
This GH commenting thing is bugged AF
Long story short, you can preserve the original logic and simply add the _getBlockName for the check
- // Checks if the selected block lives within a pattern.
- const {
- getBlockParentsByBlockName: _getBlockParentsByBlockName,
- getSelectedBlockClientId: _getSelectedBlockClientId,
- } = select( blockEditorStore );
- const parentCoreBlocks = _getBlockParentsByBlockName(
- _getSelectedBlockClientId(),
- SYNCED_PATTERN_BLOCK_NAME
- );
+ // Checks if the selected block lives within a pattern.
+ const {
+ getBlockParentsByBlockName: _getBlockParentsByBlockName,
+ getSelectedBlockClientId: _getSelectedBlockClientId,
+ getBlockName: _getBlockName,
+ } = select( blockEditorStore );
+ const selectedClientId = _getSelectedBlockClientId();
+ // Check if the selected block itself is a footnotes block.
+ if ( ! selectedClientId ||
+ _getBlockName( selectedClientId ) === FOOTNOTES_BLOCK_NAME
+ ) {
+ return false;
+ }
+
+ const parentCoreBlocks = _getBlockParentsByBlockName(
+ selectedClientId,
+ SYNCED_PATTERN_BLOCK_NAME
+ );
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevents adding footnotes inside footnotes blocks by checking if the selected block is within a footnotes block before enabling the footnote format.
Unless this was intentional and I can't get it to work?
Why?
To prevent this:
Kapture.2025-12-31.at.13.41.09.mp4
How?
isFootnotesSupportedto detect if the selected block has a footnotes block as a parentTesting Instructions
Screenshots or screencast