Fix storybook:dev race condition with dev script #74290
Open
+20
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzoorwanijk
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
manzoorwanijk
added
the
[Type] Build Tooling
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
manzoorwanijk
force-pushed
the
fix/dev/race-condition
branch
from
1a00f19 to
c002981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted out of #74143 (comment)
What?
This fixes the race condition in
npm run storybook:dev. The.dev-readymarker was created beforewp-build --watchfinished its initial transpilation, allowing Storybook to start while packages were still being built. This latent bug became apparent with Storybook 9's faster startup, causing "Module not found" errors for@wordpress/*packages.The fix waits for wp-build to output "Watching for changes..." before creating the marker.
Why?
How?
Testing Instructions
npm run devandnpm run storybook:devSIGINT-Ctrl + cTesting Instructions for Keyboard
Screenshots or screencast