Tag Cloud, Archives: Fix sidebar flash when changing settings #74291
+22
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -16 B (0%) Total Size: 2.59 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
fix/html-renderer-flash
branch
from
0eab4f0 to
b8cc7bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #74248
What? Why?
We are refactoring the dynamic blocks with
useServerSideRenderhook andHtmlRenderercomponent, but we were not rendering theInspectorControlscomponent while loading server-side content. As a result, the sidebar flickers when the settings are changed in the sidebar. To prevent this, I think we need to render theInspectorControlsconsistently.How?
https://github.com/WordPress/gutenberg/pull/74291/changes?diff=unified&w=1
Testing Instructions
Screenshots or screencast
Before
3f58d8370a0b061064c4269f4798a2c1.mp4
After
0fc184802a04b3b094f723989019a43e.mp4