Media & Text: Respect image_default_link_type option #74295
+38
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the WordPress `image_default_link_type` option is set to `file` or `post`, the Image block and Gallery block automatically link images to the media file or attachment page upon selection. This behavior was missing from the Media & Text block. This commit updates the `attributesFromMedia` function in the Media & Text block to read the WordPress default link setting from `window.wp.media.view.settings.defaultProps.link` when no `linkDestination` is already set, following the same pattern used by the Image block. The fix: - Adds the `LINK_DESTINATION_NONE` constant to the Media & Text block - Reads the WordPress default link type option when selecting an image - Maps WordPress constants (`file`, `post`) to Gutenberg constants (`media`, `attachment`) - Sets both `linkDestination` and `href` attributes accordingly - Only applies to images, not videos Fixes #60222
The TODO comment mentioned updating the media-text block, which is now addressed in the previous commit.
jorgefilipecosta
requested review from
ajitbohra and
fabiankaegy
as code owners
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +83 B (0%) Total Size: 2.59 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60222
This PR updates the Media & Text block to respect the WordPress
image_default_link_typeoption when selecting images.When the
image_default_link_typeoption is set tofileorpost, the Image block and Gallery block automatically link images to the media file or attachment page upon selection. However, the Media & Text block was not respecting this setting.This was noted in the Image block code with a TODO comment: "fix this in a follow up PR, requires updating media-text and ui component.
This PR just fixes the issue following exactly the same logic we use on image and gallery blocks:
linkDestinationis not already set when an image is selectedwindow.wp.media.view.settings.defaultProps.linkfile,post) to Gutenberg constants (media,attachment)linkDestinationandhrefattributes accordinglyThe fix only applies to images, not videos (matching the behavior of other blocks).
Testing Instructions
Also test:
image_default_link_typetopostshould link to the attachment pageimage_default_link_typetononeshould not add any linklinkDestinationshould not be affectedlinkDestination