-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Storybook: Always load design tokens in Design System section #74899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
| import mediaFieldsLtr from '../package-styles/media-fields-ltr.lazy.scss?inline'; | ||
| import mediaFieldsRtl from '../package-styles/media-fields-rtl.lazy.scss?inline'; | ||
| import ui from '../package-styles/ui.lazy.scss?inline'; | ||
| import designTokens from '../package-styles/design-tokens.lazy.scss?inline'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to better match the content.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 3.1 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 480538f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21292832126
|
What?
Tweaks the Storybook setup so the design tokens stylesheet is always loaded on stories within the Design System section.
Why?
@fcoveram encountered an inconvenience when adding patterns documentation stories, within the Design System section but outside the Components folder. I think it would be more straightforward to load the tokens stylesheet everywhere in the Design System section, not just the Components folder.
Testing Instructions
Smoke test some stories in the Design System section of the Storybook to see that the design tokens are being loaded.