Add image output formats and interlace settings to REST API client #74908
+69
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds image_sizes and image_size_threshold to the root endpoint preload paths to prevent an extra API request in the block editor. This fixes the "Should make no requests before the iframe is loaded" e2e test. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
[Package] Core data
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adamsilverstein
added
[Feature] Client Side Media
Expose image_output_formats, jpeg_interlaced, png_interlaced, and gif_interlaced settings from the REST API to the client-side media processing pipeline. These settings allow the client to respect server-side image_editor_output_format filter configurations and progressive/interlaced encoding preferences. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
adamsilverstein
force-pushed
the
74361-use-rest-api-for-media-settings
branch
from
d39b171 to
b15f1cc
Compare
github-actions
bot
added
[Package] Core data
adamsilverstein
force-pushed
the
feature/client-side-media-dev
branch
from
63e8707 to
8383b9c
Compare
|
Size Change: +159 B (+0.01%) Total Size: 3.1 MB
ℹ️ View Unchanged
|
…for-media-settings
…for-media-settings
Adds image_sizes and image_size_threshold to the root endpoint preload paths to prevent an extra API request in the block editor. This fixes the "Should make no requests before the iframe is loaded" e2e test. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Expose image_output_formats, jpeg_interlaced, png_interlaced, and gif_interlaced settings from the REST API to the client-side media processing pipeline. These settings allow the client to respect server-side image_editor_output_format filter configurations and progressive/interlaced encoding preferences. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Flaky tests detected in d161775. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21308481781
|
adamsilverstein
requested review from
Copilot
and removed request for
ellatrix
adamsilverstein
removed
[Package] Editor
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 7.0 Editor Tasks
adamsilverstein
moved this from 🔎 Needs Review
to 🏗️ In Progress
in WordPress 7.0 Editor Tasks
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the REST API integration for client-side media processing by adding image output format mapping and interlace settings. These settings were previously only available through editor settings and are now being migrated to the REST API as part of the ongoing media processing infrastructure improvements.
Changes:
- Added TypeScript type definitions for
imageOutputFormats,jpegInterlaced,pngInterlaced, andgifInterlacedto the upload-media store Settings interface - Updated the editor provider to fetch the new settings from the REST API's
__unstableBaseendpoint and pass them through to block editor settings - Modified the block-editor provider to include the new settings in the media upload configuration
- Added PHP unit tests to verify the
gutenberg_get_default_image_output_formats()function behavior with and without filters
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| phpunit/experimental/media/media-processing-test.php | Adds unit tests for gutenberg_get_default_image_output_formats() function to verify default behavior and filter integration |
| packages/upload-media/src/store/types.ts | Extends Settings interface with new image processing configuration fields including output formats and interlace settings |
| packages/editor/src/components/provider/use-block-editor-settings.js | Retrieves new image processing settings from REST API and includes them in block editor settings |
| packages/block-editor/src/components/provider/use-media-upload-settings.js | Passes through the new image processing settings to the media upload configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamsilverstein
moved this from 🏗️ In Progress
to 🔎 Needs Review
in WordPress 7.0 Editor Tasks
github-actions
bot
added
[Package] Editor
Member
|
@adamsilverstein needs refresh ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
image_output_formats,jpeg_interlaced,png_interlaced, andgif_interlacedsettings from the REST API to the client-side media processing pipelinegutenberg_get_default_image_output_formats()functionTest plan
image_output_formats,jpeg_interlaced,png_interlaced, andgif_interlacedwhen logged in as an adminnpm run test:unit:php -- --filter="Media_Processing_Test"Closes #74361
🤖 Generated with Claude Code