Skip to content

Conversation

@SirLouen
Copy link
Member

@SirLouen SirLouen commented Jan 24, 2026

Why?

  1. Currently Inserter block is not full testable without sample blocks
    https://wordpress.github.io/gutenberg/?path=/docs/blockeditor-inserter--docs
  2. Also there is not a full behaviour with popup as we can see in the wild.

How?

  1. Firstly, I mimic the behaviour of block-mover adding the registerCoreBlocks so we can see real content within the inserter.
  2. Secondly I add a "Full Inserter" story, similar to the QuickInserter one, which mimics the popup element that happens within the editor.

This is going to be particularly useful to showcase in tickets like: #74920

Testing Instructions

  1. Run the storybook
  2. Go to the Inserter
  3. Check for the Full Inserter, it should open, close with the X, close when clicking outside.

Testing Instructions for Keyboard

  1. It should also close with ESC

Screenshots or screencast

image

@SirLouen SirLouen requested a review from ellatrix as a code owner January 24, 2026 21:21
@SirLouen SirLouen self-assigned this Jan 24, 2026
@github-actions github-actions bot added the [Package] Block editor /packages/block-editor label Jan 24, 2026
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SirLouen <sirlouen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@SirLouen SirLouen added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement. and removed [Package] Block editor /packages/block-editor labels Jan 24, 2026
@SirLouen SirLouen requested a review from Mamaduka January 24, 2026 21:23
@SirLouen SirLouen added [Package] Block editor /packages/block-editor Needs Testing Needs further testing to be confirmed. and removed Needs Testing Needs further testing to be confirmed. labels Jan 24, 2026
Comment on lines +16 to +17
// For the purpose of this story, we need to register the core blocks samples.
registerCoreBlocks();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be invoked for this story alone, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Testing Needs further testing to be confirmed. [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants