Resolve ambiguous column names in ORDER BY#231
Closed
Conversation
Collaborator
Author
|
@JanJakes It seems like it works but something's off in the CI setup with the TLS certificate errors. I won't be able to address that today – would you be able to take over? |
adamziel
commented
Aug 29, 2025
| * @see https://github.com/wordpress/sqlite-database-integration/issues/228 | ||
| * @var array<int, array<string, string|null>> Stack of frames: name(lowercase) → expression|null | ||
| */ | ||
| private $select_output_name_to_ordinal_stack = array(); |
Collaborator
Author
There was a problem hiding this comment.
I don't like this name. Maybe $selected_columns_stack?
Member
|
Oh wow, what a complexity (maintaining the stack, etc.) and dirty code. Nope, GPT-5, not good. I had something much simpler in mind with a top-down approach. Gave it a quick shot in #232. The first commit is all that is needed, the second one covers an advanced edge case. I think it's almost good to go and likely much more correct. I will double-check and finalize it tomorrow. |
adamziel
added a commit
that referenced
this pull request
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 WIP 🚧
GPT 5-assisted solution for #230. The logic seems in tact, this PR needs reformatting and a pass over the comments to better explain the context
Follow-up work
Explore whether this solution needs to also be applied to column names in LIMIT, HAVING, GROUP BY, etc.