Skip to content

Use a dataprover in db tests #10466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+27 −18
Open

Use a dataprover in db tests #10466

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5a08d2
dataproviders allow for the tests to all run rather than stopping at …
aaronjorbin Nov 4, 2025
4e68fab
coding standards
aaronjorbin Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 27 additions & 18 deletions tests/phpunit/tests/db.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,28 +122,37 @@ public function test_locale_floats() {

/**
* @ticket 10041
* @dataProvider data_esc_like
Comment on lines 124 to +125
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @ticket 10041
* @dataProvider data_esc_like
* @ticket 10041
*
* @dataProvider data_esc_like
*
* @param string $input The input string.
* @param string $expected The expected escaped string.

*/
public function test_esc_like() {
public function test_esc_like( $input, $expected ) {
global $wpdb;

$inputs = array(
'howdy%', // Single percent.
'howdy_', // Single underscore.
'howdy\\', // Single slash.
'howdy\\howdy%howdy_', // The works.
'howdy\'"[[]*#[^howdy]!+)(*&$#@!~|}{=--`/.,<>?', // Plain text.
);
$expected = array(
'howdy\\%',
'howdy\\_',
'howdy\\\\',
'howdy\\\\howdy\\%howdy\\_',
'howdy\'"[[]*#[^howdy]!+)(*&$#@!~|}{=--`/.,<>?',
);
$this->assertSame( $expected, $wpdb->esc_like( $input ) );
}

foreach ( $inputs as $key => $input ) {
$this->assertSame( $expected[ $key ], $wpdb->esc_like( $input ) );
}
public function data_esc_like() {
return array(
'single percent' => array(
'howdy%',
'howdy\\%',
),
'single underscore' => array(
'howdy_',
'howdy\\_',
),
'single slash' => array(
'howdy\\',
'howdy\\\\',
),
'the works' => array(
'howdy\\howdy%howdy_',
'howdy\\\\howdy\\%howdy\\_',
),
'plain text' => array(
'howdy\'"[[]*#[^howdy]!+)(*&$#@!~|}{=--`/.,<>?',
'howdy\'"[[]*#[^howdy]!+)(*&$#@!~|}{=--`/.,<>?',
),
);
}

/**
Expand Down
Loading