-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Notes unexpected do not notify post author (unlike comments) #10472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
adamsilverstein
wants to merge
24
commits into
WordPress:trunk
from
adamsilverstein:add/notes-notifications
Closed
Changes from 10 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8ec209c
Send a notification to the post author when a note is added
adamsilverstein 6799a1d
phpcbf
adamsilverstein 6faacfe
remove notes conditional
adamsilverstein b3487af
Only notify on notes REST insert
adamsilverstein 0daba4c
update docblock
adamsilverstein cbfef88
Queue note notifications with cron
adamsilverstein f089d47
Skip notifications for empty notes
adamsilverstein 79fd7e5
Update src/wp-includes/pluggable.php
adamsilverstein 2aa7c96
Whitespace
adamsilverstein f9d4686
adjust since
adamsilverstein 79aa49d
Revert "Queue note notifications with cron"
adamsilverstein 8da27bc
update: Anyone posts a comment + "or note"
adamsilverstein 98c2873
Add separate notes notification setting
adamsilverstein 099de2f
Move notification hook so it is always available when action triggered
adamsilverstein 887974e
Empty notes are resolution/reopen events
adamsilverstein 62ed6c3
Fix notification logic
adamsilverstein 25f0b56
phpcbf
adamsilverstein f3bee16
Check comment object returned before using
adamsilverstein 0f6fff0
Merge branch 'trunk' into add/notes-notifications
adamsilverstein 3b168e3
Update comment.php
adamsilverstein 6fd6294
Update class-wp-rest-comments-controller.php
adamsilverstein 93b9bd1
PHP not react
adamsilverstein 7a1ed8e
rename notes_notify -> wp_ notes_notify
adamsilverstein 2f4c927
Move wp_ notes_notify to bottom and add comment
adamsilverstein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.