Skip to content

Update Twemoji CDN endpoint for Twemoji 17.0.2 files. #10492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

Update Twemoji CDN endpoint for Twemoji 17.0.2 files. #10492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1f7dac7
Update CDN for 17.0.2 assets.
peterwilsoncc Nov 7, 2025
337a58d
Pull file list for 17.0.2 from gh-pages branch.
peterwilsoncc Nov 7, 2025
4d8b0bb
Revert "Pull file list for 17.0.2 from gh-pages branch."
peterwilsoncc Nov 7, 2025
a66d728
REVERT THIS: put a line break between entities so I can see what chan…
peterwilsoncc Nov 7, 2025
9f04266
Revert "Revert "Pull file list for 17.0.2 from gh-pages branch.""
peterwilsoncc Nov 7, 2025
9f4ee73
Revert "REVERT THIS: put a line break between entities so I can see w…
peterwilsoncc Nov 7, 2025
5f2eed6
Automation: Updating built files with changes.
Nov 7, 2025
6793d57
Update count tests.
peterwilsoncc Nov 7, 2025
1f7c5c4
Twemoji.js uses spaces for indenting.
peterwilsoncc Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ module.exports = function(grunt) {
}

// Fetch a list of the files that Twemoji supplies.
query = 'query={repository(owner: "jdecked", name: "twemoji") {object(expression: "v17.0.1:assets/svg") {... on Tree {entries {name}}}}}';
query = 'query={repository(owner: "jdecked", name: "twemoji") {object(expression: "gh-pages:v/17.0.2/svg") {... on Tree {entries {name}}}}}';
files = spawn( 'gh', [ 'api', 'graphql', '-f', query] );

if ( 0 !== files.status ) {
Expand Down
2 changes: 1 addition & 1 deletion src/js/_enqueues/vendor/twemoji.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ var twemoji = (function (
how = {callback: how};
}

// WP start
// WP start
// Allow passing of the doNotParse() callback in the settings.
// The callback is used in `grabAllTextNodes()` (DOM mode only) as a filter
// that allows bypassing of some of the text nodes. It gets the current subnode as argument.
Expand Down
8 changes: 4 additions & 4 deletions src/wp-includes/formatting.php
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions tests/phpunit/tests/formatting/emoji.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
*/
class Tests_Formatting_Emoji extends WP_UnitTestCase {

private $png_cdn = 'https://s.w.org/images/core/emoji/17.0.1-1/72x72/';
private $svg_cdn = 'https://s.w.org/images/core/emoji/17.0.1-1/svg/';
private $png_cdn = 'https://s.w.org/images/core/emoji/17.0.2/72x72/';
private $svg_cdn = 'https://s.w.org/images/core/emoji/17.0.2/svg/';

/**
* @ticket 63842
Expand Down Expand Up @@ -122,15 +122,15 @@ public function test_wp_emoji_list_returns_data() {
$entities = _wp_emoji_list( 'entities' );
$this->assertNotEmpty( $entities, 'Entities should not be empty' );
$this->assertIsArray( $entities, 'Entities should be an array' );
// Emoji 15 contains 3718 entities, this number will only increase.
$this->assertGreaterThanOrEqual( 3718, count( $entities ), 'Entities should contain at least 3718 items' );
// Emoji 17 contains 4007 entities, this number will only increase.
$this->assertGreaterThanOrEqual( 4007, count( $entities ), 'Entities should contain at least 4007 items' );
$this->assertSame( $default, $entities, 'Entities should be returned by default' );

$partials = _wp_emoji_list( 'partials' );
$this->assertNotEmpty( $partials, 'Partials should not be empty' );
$this->assertIsArray( $partials, 'Partials should be an array' );
// Emoji 15 contains 1424 partials, this number will only increase.
$this->assertGreaterThanOrEqual( 1424, count( $partials ), 'Partials should contain at least 1424 items' );
// Emoji 17 contains 1438 partials, this number will only increase.
$this->assertGreaterThanOrEqual( 1438, count( $partials ), 'Partials should contain at least 1438 items' );

$this->assertNotSame( $default, $partials );
}
Expand Down
Loading