-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Bundled themes version bumps for WordPress 6.9 #10493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
…package-lock.json
…, package-lock.json, file-header.scss
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| // Theme block stylesheet. | ||
| wp_enqueue_style( 'twentytwelve-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentytwelve-style' ), '20240812' ); | ||
| wp_enqueue_style( 'twentytwelve-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentytwelve-style' ), '20251101' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 20251202
| wp_enqueue_style( 'twentytwelve-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentytwelve-style' ), '20251101' ); | |
| wp_enqueue_style( 'twentytwelve-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentytwelve-style' ), '20251202' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These blocks stylesheets usually have a version string on the last modified date, and r61107 was the most recent change for Twenty Twelve's. And according to UTC, the date was still 20251031 for 87 minutes :)
Ultimately, these just need to be strings that no sites should have used yet.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
I'm not ready to do a thorough review, but I have two comments.
|
|
All the mentioned feedback has been incorporated in the latest commit. |
Twenty Ten: 4.5
Twenty Eleven: 5.0
Twenty Twelve: 4.7
Twenty Thirteen: 4.5
Twenty Fourteen: 4.4
Twenty Fifteen: 4.1
Twenty Sixteen: 3.7
Twenty Seventeen: 4.0
Twenty Nineteen: 3.2
Twenty Twenty: 3.0
Twenty Twenty-One: 2.7
Twenty Twenty-Two: 2.1
Twenty Twenty-Three: 1.6
Twenty Twenty-Four: 1.4
Twenty Twenty-Five: 1.4
Trac ticket: #60999