Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync packages for WordPress 6.7 RC4 #7745

Closed
wants to merge 1 commit into from

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Nov 7, 2024

Syncs Editor packages for WordPress 6.7 RC4. Includes the following PRs:

Trac ticket: https://core.trac.wordpress.org/ticket/62358


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Nov 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props get_dave, mikachan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@getdave
Copy link
Contributor Author

getdave commented Nov 7, 2024

Noting that there is no src/wp-includes/assets/script-loader-packages.min.php in this diff.

Previous package syncs have included this (example)

Copy link

github-actions bot commented Nov 7, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mikachan
Copy link
Member

mikachan commented Nov 7, 2024

Noting that there is no src/wp-includes/assets/script-loader-packages.min.php in this diff.

Based on this Slack conversation (great summary here), we figured out that since this package update only includes CSS changes, then the versions in this file do not need to be updated, as they're only for the JS files.

These updates are testing well for me based on the fixes described in the two included GB PRs 👍

@getdave
Copy link
Contributor Author

getdave commented Nov 7, 2024

@getdave getdave closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants