Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header: Add hover style behind logo #366

Closed
1 task
jasmussen opened this issue Mar 27, 2023 · 2 comments · Fixed by #379
Closed
1 task

Header: Add hover style behind logo #366

jasmussen opened this issue Mar 27, 2023 · 2 comments · Fixed by #379
Assignees
Labels
[Block] Header & Footer [Type] Enhancement New feature or request [Type] Question Further information is requested

Comments

@jasmussen
Copy link
Collaborator

jasmussen commented Mar 27, 2023

We should add a hover style to the logo. Currently, the hover style is that of a dark background, and underlined text. We could apply that:

hover option 1

  • Add background color on logo hover

This is likely the best and simplest route to go, as it leans into established patterns. Be mindful that the left/right padding of the navigation menu itself needs to be increased a little, so that the logo button can have uniform padding left and right. At the moment, the logo has additional padding to the left, for positioning purposes, which would make the hover style awkward.

@jasmussen jasmussen added [Type] Enhancement New feature or request [Type] Question Further information is requested labels Mar 27, 2023
@ryelle ryelle transferred this issue from WordPress/wporg-main-2022 Mar 28, 2023
@ryelle ryelle changed the title Unify logo appearance and size, add hover style Header: Unify logo appearance and size, add hover style Mar 28, 2023
@ryelle
Copy link
Contributor

ryelle commented Mar 28, 2023

@jasmussen Can you move the parts of this issue related to /gutenberg/ to https://github.com/WordPress/wporg-gutenberg/? I think then the only part of this issue remaining would be adding the background color to the logo's hover state, and we can remove the "question" label.

@jasmussen
Copy link
Collaborator Author

Extracted into WordPress/wporg-gutenberg#55

@ryelle ryelle changed the title Header: Unify logo appearance and size, add hover style Header: Add hover style behind logo Mar 29, 2023
@ryelle ryelle moved this from 🛑 Pending discussion to 📋 To do in WordPress.org Redesign Mar 29, 2023
@ryelle ryelle self-assigned this Mar 29, 2023
@ryelle ryelle moved this from 📋 To do to 🏗 In progress in WordPress.org Redesign Mar 30, 2023
@ryelle ryelle moved this from 🏗 In progress to ✅ Done in WordPress.org Redesign Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Header & Footer [Type] Enhancement New feature or request [Type] Question Further information is requested
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants