Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header: Add background to logo on hover #379

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Mar 30, 2023

Fixes #366 — Add the hover color behind the logo.

Default Blue White Classic
branch-default-1 branch-blue-1 branch-white-1 branch-old-1
branch-default-2 branch-blue-2 branch-white-2 branch-old-2

@ryelle ryelle requested a review from a team March 30, 2023 15:13
@ryelle ryelle self-assigned this Mar 30, 2023
@jasmussen
Copy link
Collaborator

Thanks for doing this. It's a bit hard for me to compare the before and after, here's my best attempt:

Screenshot 2023-03-31 at 08 55 57

From the inspector, this seems like it should be fine, because the padding of the logo button is uniform:

Screenshot 2023-03-31 at 08 57 01

So it looks good (ship it).

When I initially created 366, though, I thought I recalled a non-uniform padding that might have needed finessing. But that may have been from the figma mockups:

Screenshot 2023-03-31 at 08 58 54

@ryelle ryelle merged commit d00d42b into trunk Mar 31, 2023
@ryelle ryelle deleted the update/header-logo-hover branch March 31, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Header: Add hover style behind logo
2 participants