Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global footer: Update footer menu items #464

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Oct 2, 2023

Fixes #364.

This updates the menu structure to match the layout in this comment: #364 (comment)

Before
image

After
image1

Warning
Ideally, this PR should be merged alongside #458.

@ndiego ndiego requested a review from ryelle October 2, 2023 17:10
@ndiego ndiego marked this pull request as ready for review October 2, 2023 17:10
@ndiego ndiego requested a review from renintw October 2, 2023 17:10
@ryelle
Copy link
Contributor

ryelle commented Oct 2, 2023

Does this make #450 unnecessary?

@ryelle
Copy link
Contributor

ryelle commented Oct 2, 2023

Also, I think I'm going to merge #455 as soon as I fix the padding that @StevenDufresne mentioned, so that will put this PR into conflict. Would you want me to resolve it?

@ndiego
Copy link
Member Author

ndiego commented Oct 2, 2023

Does this make #450 unnecessary?

Yup, just closed!

Also, I think I'm going to merge #455 as soon as I fix the padding that @StevenDufresne mentioned, so that will put this PR into conflict. Would you want me to resolve it?

I can try fixing it once merged.

@ryelle
Copy link
Contributor

ryelle commented Oct 2, 2023

Okay, #455 was merged and as expected this has conflicts now (sorry!)

@ndiego ndiego changed the title Global header: Update footer menu items Global footer: Update footer menu items Oct 3, 2023
@StevenDufresne
Copy link
Contributor

Noting that there is also this footer PR open that could get addressed now as well since it will conflict and the changes are somewhat related.

Link: #319

@renintw
Copy link
Contributor

renintw commented Oct 9, 2023

👍 Done testing and the results are consistent with what the description outlines. It's good for merging once the conflicts are resolved.

Additionally, I saw that the removal of the Public Code link would need confirmation. Has this been confirmed somewhere, or is it still under discussion? If we add the links from #319, there may not be a need to remove the Public Code, and it could still align well.

@pkevan pkevan merged commit eb5eba4 into WordPress:trunk Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Footer: Revisit footer links and categorize
5 participants