-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global footer: Update footer menu items #464
Conversation
Does this make #450 unnecessary? |
Also, I think I'm going to merge #455 as soon as I fix the padding that @StevenDufresne mentioned, so that will put this PR into conflict. Would you want me to resolve it? |
Yup, just closed!
I can try fixing it once merged. |
Okay, #455 was merged and as expected this has conflicts now (sorry!) |
👍 Done testing and the results are consistent with what the description outlines. It's good for merging once the conflicts are resolved. Additionally, I saw that the removal of the Public Code link would need confirmation. Has this been confirmed somewhere, or is it still under discussion? If we add the links from #319, there may not be a need to remove the Public Code, and it could still align well. |
Fixes #364.
This updates the menu structure to match the layout in this comment: #364 (comment)
Before
After