Single Site: Update site meta list #144
Conversation
| 'key' => 'country', | ||
| ), | ||
| array( | ||
| 'label' => __( 'Theme', 'wporg' ), | ||
| 'key' => 'theme', | ||
| 'label' => __( 'Category', 'wporg' ), |
There was a problem hiding this comment.
Should we limit the category to 1?
There was a problem hiding this comment.
Is the issue that you don't want to see Featured? We can omit that category, but I don't think this value needs to be limited to one.
| white-space: nowrap; | ||
| padding-right: 1rem; | ||
| } | ||
| li { |
There was a problem hiding this comment.
Noting, in the designs, the links are text-decoration: none;.
| <!-- /wp:heading --> | ||
|
|
||
| <!-- wp:wporg/site-meta-list /--> | ||
| </div> | ||
| <!-- /wp:group --> | ||
|
|
||
| <!-- wp:paragraph {"style":{"spacing":{"margin":{"top":"var:preset|spacing|30"}}}} --> | ||
| <p style="margin-top:var(--wp--preset--spacing--30)"><a href="<?php echo esc_url( home_url( '/tags/' ) ); ?>"><?php _e( 'View all tags', 'wporg' ); ?></a></p> |
There was a problem hiding this comment.
I think margin-top:var(--wp--preset--spacing--20) feels more natural. Not a strong opinion.
There was a problem hiding this comment.
It's 30px in the design, and also like I mentioned, the spacing conversation is ongoing so I didn't aim for perfection.
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| } | ||
| .wp-block-wporg-site-meta-list { |
There was a problem hiding this comment.
It gets a bit tight at 895px.
There was a problem hiding this comment.
We can iterate on the responsive style of the page as part of #132
|
I'm going to merge this so I can get it on the staging site, but we can keep iterating on it. |
See #132 — The site information section has been redesigned to list out each meta value and taxonomy separately. It also updates the layout of the single site page to better match the design, though with the spacing conversation ongoing I didn't aim for perfection.
The taxonomy values are links (so you can click to navigate to all sites tagged "dining"), while the meta field items are not links (there was no plan to allow filtering by these).
Screenshots
Some examples of different sites with various meta filled in or not.
To test