Archives: Update the main heading on all filter views #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180 — This updates the query-title block so that it always outputs heading text on filtered archive views. The heading is still invisible, it's currently there for screen reader users & SEO.
For example:
/archives/?tag[]=dining
— "Filter by: Dining"/archives/?tag[]=dining&cat[]=3
— "Filter by: Dining, Featured"/archives/?cat[]=3&s=restaurant
— Filter by: Featured, restaurantTo test
Try any number of filter combinations on the archives page. There should always be an h1 on the page, and the title should match the current filters. You can use a bookmarklet like this one to test.
Also check the document title, it should reflect the currently-selected filters too.
If you want, switch out the
query-title
inpatterns/_site-grid.php
with the following, for a visible heading.