Remove unnecessary blocking style requests #237
Conversation
adamwoodnz
force-pushed
the
fix/233-performance
branch
from
01c8d3d
to
2167efc
Compare
| @@ -39,6 +40,8 @@ | |||
| add_filter( 'grunion_should_send_email', '__return_false' ); | |||
| // Enable auto-fill using user information. | |||
| add_filter( 'jetpack_auto_fill_logged_in_user', '__return_true' ); | |||
| // Remove Jetpack CSS on frontend | |||
| add_filter( 'jetpack_implode_frontend_css', '__return_false', 99 ); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Good find. Looping in @pkevan since he has more experience with JetPack than I do. The front-end and form still appear to work as expected. 👍
There was a problem hiding this comment.
Yeah the Jetpack docs describe the intention of this filter quite differently, but I've found multiple sources using it for this purpose.
There was a problem hiding this comment.
When there is something like this found, it's usually best to highlight it with Jetpack themselves, as it could be an opportunity on their side to optimise or a bug in the implementation itself.
There was a problem hiding this comment.
highlight it with Jetpack themselves
Good call, I'll raise this and see if there's a better way to remove this CSS too, as neither dequeue or deregister work.
See #233
The current lighthouse performance score is consistently < 80.
In my sandbox it's between 80 and 90 before these changes. The biggest contributing factor is the LCP metric, and a major factor in that is render blocking styles for dashicons and jetpack:
We don't need either of these on the frontend as far as I can see, so this PR fixes that opportunity by removing them. This results in a score > 90, due to an improved LCP metric:
The initial server response time is bad for me accessing my sandbox in NZ, and is considerably better in prod, so I think we can work on these resource loading optimisations first, and look at server response next if necessary.
Testing
Best to use a sandbox to be as close as possible to prod, and an incognito tab so that no extensions can interfere with results. Run a Lighthouse performance test with and without these changes and compare.
Check that Jetpack and the admin in general still have their required CSS loaded.