Skip to content

chore: Add better guidance around styling #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mannycarrera4
Copy link
Contributor

Summary

Fixes: #3275

Release Category

Documentation


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

Copy link

cypress bot commented May 8, 2025

Workday/canvas-kit    Run #8838

Run Properties:  status check passed Passed #8838  •  git commit 32d7ee3f42 ℹ️: Merge f13efed2416af85573bd53409e3949f8d69f4577 into 885784bd65fe9a445b16d7b7ac21...
Project Workday/canvas-kit
Branch Review mc-styling-docs-update
Run status status check passed Passed #8838
Run duration 02m 49s
Commit git commit 32d7ee3f42 ℹ️: Merge f13efed2416af85573bd53409e3949f8d69f4577 into 885784bd65fe9a445b16d7b7ac21...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 936
View all changes introduced in this branch ↗︎
UI Coverage  21.36%
  Untested elements 1522  
  Tested elements 411  
Accessibility  99.28%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 98  

@mannycarrera4
Copy link
Contributor Author

closing this and lumping this work into #3280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a Overview of our styling approach including our preferences
1 participant