Skip to content

fix(multi-select): Support items update in selection pills #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

NicholasBoll
Copy link
Member

Summary

Fixes #3332

Release Category

Components


Checklist

  • Label ready for review has been added to PR

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

@NicholasBoll NicholasBoll added the ready for review Code is ready for review label Jun 11, 2025
Copy link

cypress bot commented Jun 11, 2025

Workday/canvas-kit    Run #8920

Run Properties:  status check passed Passed #8920  •  git commit b7b6c1b7df ℹ️: Merge f1d46cd1eaff59aec03606e313aaf564f5bf9ace into 67c9a9e99936c8c7acf0e3a8e267...
Project Workday/canvas-kit
Branch Review fix/multi-select-dynamic-items
Run status status check passed Passed #8920
Run duration 02m 51s
Commit git commit b7b6c1b7df ℹ️: Merge f1d46cd1eaff59aec03606e313aaf564f5bf9ace into 67c9a9e99936c8c7acf0e3a8e267...
Committer Nicholas Boll
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 936
View all changes introduced in this branch ↗︎
UI Coverage  21.31%
  Untested elements 1523  
  Tested elements 410  
Accessibility  99.28%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 98  

@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels Jun 12, 2025
@alanbsmith alanbsmith merged commit e70516f into support Jun 12, 2025
24 checks passed
@alanbsmith alanbsmith deleted the fix/multi-select-dynamic-items branch June 12, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants