Skip to content

chore: Update chromatic action settings #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

RayRedGoose
Copy link
Contributor

Summary

Fixes: #3344

Updated inputs for chromatic.

Release Category

Infrastructure

@RayRedGoose RayRedGoose self-assigned this Jun 17, 2025
@RayRedGoose RayRedGoose added the ready for review Code is ready for review label Jun 17, 2025
@RayRedGoose RayRedGoose changed the base branch from master to support June 17, 2025 18:29
Copy link

cypress bot commented Jun 17, 2025

Workday/canvas-kit    Run #8949

Run Properties:  status check passed Passed #8949  •  git commit 1e9903401f ℹ️: Merge c5bc13b6a786a4843fd9f1d0456a2e64d72f9240 into a8eaa7da896186d3ed4c093dccff...
Project Workday/canvas-kit
Branch Review fix-action
Run status status check passed Passed #8949
Run duration 02m 57s
Commit git commit 1e9903401f ℹ️: Merge c5bc13b6a786a4843fd9f1d0456a2e64d72f9240 into a8eaa7da896186d3ed4c093dccff...
Committer Raisa Primerova
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 936
View all changes introduced in this branch ↗︎
UI Coverage  21.24%
  Untested elements 1529  
  Tested elements 410  
Accessibility  99.29%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 98  

@@ -82,7 +82,7 @@ jobs:
- uses: chromaui/action@main
with:
token: ${{ secrets.GITHUB_TOKEN }}
appCode: dlpro96xybh
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this works. We already used to use a GH secret. The problem is pull requests from forks are not trusted, so GH Actions sends an empty string for any secret. This change will simply send an empty string to Chromatic.

The documentation isn't clear:

Continuous Integration

To set up CI, store your project token as the CHROMATIC_PROJECT_TOKEN environment variable or secret. The CLI automatically recognizes this variable, so you won’t have to provide it explicitly.

Here's the GHA documentation: https://www.chromatic.com/docs/github-actions/#forked-repositories

Forked repositories

GitHub secrets work at a repository level. Forked repositories will not have access to them. If you want to run Chromatic on cross-repository (forked) PRs, you’ll have to expose the projectToken by including it as plaintext in your chromatic.yml workflow file. Be aware that anyone with access to this file will be able to run Chromatic builds on your project, consuming your snapshot quota. You can reset the project token on the Manage > Configure screen at any time if you think it may have been compromised.

@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels Jun 17, 2025
@alanbsmith alanbsmith merged commit 45df49d into Workday:support Jun 17, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromatic is failed for PRs
4 participants