-
Notifications
You must be signed in to change notification settings - Fork 232
chore: Update chromatic action settings #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Workday/canvas-kit
|
Project |
Workday/canvas-kit
|
Branch Review |
fix-action
|
Run status |
|
Run duration | 02m 57s |
Commit |
|
Committer | Raisa Primerova |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
21
|
|
0
|
|
936
|
View all changes introduced in this branch ↗︎ |
UI Coverage
21.24%
|
|
---|---|
|
1529
|
|
410
|
Accessibility
99.29%
|
|
---|---|
|
6 critical
5 serious
0 moderate
2 minor
|
|
98
|
.github/workflows/pull-request.yml
Outdated
@@ -82,7 +82,7 @@ jobs: | |||
- uses: chromaui/action@main | |||
with: | |||
token: ${{ secrets.GITHUB_TOKEN }} | |||
appCode: dlpro96xybh | |||
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how this works. We already used to use a GH secret. The problem is pull requests from forks are not trusted, so GH Actions sends an empty string for any secret. This change will simply send an empty string to Chromatic.
The documentation isn't clear:
Continuous Integration
To set up CI, store your project token as the CHROMATIC_PROJECT_TOKEN environment variable or secret. The CLI automatically recognizes this variable, so you won’t have to provide it explicitly.
Here's the GHA documentation: https://www.chromatic.com/docs/github-actions/#forked-repositories
Forked repositories
GitHub secrets work at a repository level. Forked repositories will not have access to them. If you want to run Chromatic on cross-repository (forked) PRs, you’ll have to expose the projectToken by including it as plaintext in your chromatic.yml workflow file. Be aware that anyone with access to this file will be able to run Chromatic builds on your project, consuming your snapshot quota. You can reset the project token on the Manage > Configure screen at any time if you think it may have been compromised.
Summary
Fixes: #3344
Updated inputs for chromatic.
Release Category
Infrastructure