Feature: Decouple SharedItemData from code #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store it in CSV file instead, for easy updating of new items introduced in the game
jensbrak
changed the title
Contributor
Author
|
Please note that I do have a branch for the new items in Mistlands that I haven't done a PR for. It is based on this PR but the Shared Item Database needs to be revised before making it into Loki Master I believe. And possibly some more changes related to customisations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store it in CSV file instead, for easy updating of new items introduced in the game.
Replaces previous PR's. I wanted to have a clean PR with only the change of functionality.
A separate PR with data changes (added items that is still missing in Loki since Mistlands update) will come.
Based on this PR.