Skip to content

issues can now be closed as duplicate #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jcreekmore
Copy link
Contributor

Recently, GitHub added the ability to explicitly close an issue as a duplicate. When you close an issue as a duplicate, in addition to linking it to the issue and putting an event in the timeline, it also sets the the issue state reason to duplicate. I cannot find this behavior documented in the current GitHub API docs, but I have seen it in the wild on a few recent issues in the rust-analyzer repository.

Recently, GitHub added the ability to [explicitly close an issue as a
duplicate](https://github.blog/changelog/2024-12-12-github-issues-projects-close-issue-as-a-duplicate-rest-api-for-sub-issues-and-more/#close-an-issue-as-a-duplicate).
When you close an issue as a duplicate, in addition to linking it to the
issue and putting an event in the timeline, it _also_ sets the the issue
state reason to `duplicate`. I cannot find this behavior documented in
the current GitHub API docs, but I have seen it in the wild on a few
recent issues in the rust-analyzer repository.
@cwfitzgerald
Copy link

Yeah hit this in the bevy repo as well, would be great to get this in.

@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit a916714 into XAMPPRocky:main Jan 13, 2025
20 checks passed
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
@fmhall
Copy link
Contributor

fmhall commented Jan 17, 2025

Can we get this into a release? Or is there a workaround people recommend?

0xB10C added a commit to 0xB10C/github-metadata-backup that referenced this pull request Feb 14, 2025
This fixes an issue where getting an issue fails when it has been
closed as "duplicate". See XAMPPRocky/octocrab#741
0xB10C added a commit to 0xB10C/github-metadata-backup that referenced this pull request Feb 14, 2025
This fixes an issue where getting an issue fails when it has been
closed as "duplicate". See XAMPPRocky/octocrab#741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants