Skip to content

fix(docs): Update and fix crate documentation for docs.rs, update README #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025

Conversation

fmhall
Copy link
Contributor

@fmhall fmhall commented Apr 29, 2025

I went ahead and revamped the documentation, since a few modules were not being exported properly (like users) and other parts of the docs had broken links or weren't up to date with the latest features.

Closes #759, and almost all the warnings generated by cargo docs.

To test the resulting output, you can run RUSTDOCFLAGS="--cfg docsrs" rustup run nightly cargo doc --all-features --no-deps --open.

Thanks for creating Octocrab. Looking forward to upstreaming some more improvements in the future, like getting the API abstractions up to parity with Github.

As an aside, if you are open to a new source of funding for your open source work, we'd love to chat. Please feel free to reach out to me directly through twitter or my email on my website.

@fmhall
Copy link
Contributor Author

fmhall commented May 5, 2025

Doctest should be fixed now @XAMPPRocky !

@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit c80670a into XAMPPRocky:main May 6, 2025
20 checks passed
@github-actions github-actions bot mentioned this pull request May 6, 2025
@fmhall
Copy link
Contributor Author

fmhall commented May 6, 2025

Happy to help! And if you are inclined to chat about OSS funding, please let me know :)

@XAMPPRocky
Copy link
Owner

Thank you but blockchain projects are not permitted or welcome to be associated with my projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing rustdocs documentation for certain types
2 participants