fix: Commit search endpoint uses wrong type for deserialization #781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
models::repo::Commit
,author
- which is of typeCommitAuthor
(https://github.com/XAMPPRocky/octocrab/blob/main/src/models/repos.rs#L160) - has a non-optional name field. But this was causing crashes for me with the errorSerde error: missing field 'name'
as Github does not return the author name here.name
is also not present in the example response in the Github docs for this endpoint either (https://docs.github.com/en/rest/search/search?apiVersion=2022-11-28#search-commits):Using
models::commits::Commit
instead seems to work.