Skip to content

fix: Commit search endpoint uses wrong type for deserialization #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

halfdanthemild
Copy link

@halfdanthemild halfdanthemild commented Jul 2, 2025

In models::repo::Commit, author - which is of type CommitAuthor (https://github.com/XAMPPRocky/octocrab/blob/main/src/models/repos.rs#L160) - has a non-optional name field. But this was causing crashes for me with the error Serde error: missing field 'name' as Github does not return the author name here. name is also not present in the example response in the Github docs for this endpoint either (https://docs.github.com/en/rest/search/search?apiVersion=2022-11-28#search-commits):

"author": {
  "login": "octocat",
  "id": 583231,
  "node_id": "MDQ6VXNlcjU4MzIzMQ==",
  "avatar_url": "https://avatars.githubusercontent.com/u/583231?v=3",
  "gravatar_id": "",
  "url": "https://api.github.com/users/octocat",
  "html_url": "https://github.com/octocat",
  "followers_url": "https://api.github.com/users/octocat/followers",
  "following_url": "https://api.github.com/users/octocat/following{/other_user}",
  "gists_url": "https://api.github.com/users/octocat/gists{/gist_id}",
  "starred_url": "https://api.github.com/users/octocat/starred{/owner}{/repo}",
  "subscriptions_url": "https://api.github.com/users/octocat/subscriptions",
  "organizations_url": "https://api.github.com/users/octocat/orgs",
  "repos_url": "https://api.github.com/users/octocat/repos",
  "events_url": "https://api.github.com/users/octocat/events{/privacy}",
  "received_events_url": "https://api.github.com/users/octocat/received_events",
  "type": "User",
  "site_admin": false
}

Using models::commits::Commit instead seems to work.

@halfdanthemild halfdanthemild marked this pull request as ready for review July 2, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant