Fix the flag processing of NFTokenModify#5246
Merged
bthomee merged 4 commits intoXRPLF:developfrom Jan 16, 2025
Merged
Conversation
- Added a check for invalid flags
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5246 +/- ##
=========================================
- Coverage 78.0% 78.0% -0.0%
=========================================
Files 789 789
Lines 66953 66955 +2
Branches 8107 8110 +3
=========================================
- Hits 52218 52215 -3
- Misses 14735 14740 +5
... and 2 files with indirect coverage changes |
mvadari
reviewed
Jan 15, 2025
shawnxie999
reviewed
Jan 15, 2025
Collaborator
shawnxie999
left a comment
shawnxie999
left a comment
There was a problem hiding this comment.
left a few nits - otherwise looks good
shawnxie999
reviewed
Jan 15, 2025
Collaborator
shawnxie999
left a comment
shawnxie999
left a comment
There was a problem hiding this comment.
left a few nits - otherwise looks good
mvadari
approved these changes
Jan 16, 2025
shawnxie999
approved these changes
Jan 16, 2025
shawnxie999
requested changes
Jan 16, 2025
Collaborator
shawnxie999
left a comment
shawnxie999
left a comment
There was a problem hiding this comment.
@tequdev seems like some NFT tests are failing due to wrong count
shawnxie999
approved these changes
Jan 16, 2025
Collaborator
shawnxie999
left a comment
shawnxie999
left a comment
There was a problem hiding this comment.
looks good. @tequdev do you think this ready to merge?
Member
Author
yes, ready to merge. |
mvadari
added
the
Ready to merge
q73zhao
pushed a commit
that referenced
this pull request
Feb 24, 2025
Adds checks for invalid flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
#5048 (comment)
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)