Skip to content

Conversation

@pratikmankawde
Copy link
Collaborator

High Level Overview of Change

This change retires the fix1571 amendment.

Context of Change

Original amendment: https://xrpl.org/resources/known-amendments#fix1571
Amendments activated for more than 2 years can be retired.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <[email protected]>
@pratikmankawde pratikmankawde requested a review from a team as a code owner October 23, 2025 12:02
@pratikmankawde pratikmankawde requested review from ximinez and removed request for a team October 23, 2025 12:02
env(escrow::finish("carol", "alice", seqFt), fee(150 * baseFee));
BEAST_EXPECT(
env.balance("bob") ==
XRP(5200)); // 5100 (from last transaction) + 100
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ximinez Can you please confirm if this new unit test which checks presence of cancel time and finish time combination is correct?

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.5%. Comparing base (e192ffe) to head (06e0766).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5925   +/-   ##
=======================================
  Coverage     78.5%   78.5%           
=======================================
  Files          817     817           
  Lines        69017   69013    -4     
  Branches      8276    8275    -1     
=======================================
- Hits         54197   54196    -1     
+ Misses       14820   14817    -3     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/Escrow.cpp 99.2% <100.0%> (-<0.1%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pratikmankawde pratikmankawde requested review from a1q123456 and vvysokikh1 and removed request for ximinez October 24, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant