Conversation
pratikmankawde
requested review from
a team and
ximinez
and removed request for
a team
| env(escrow::finish("carol", "alice", seqFt), fee(150 * baseFee)); | ||
| BEAST_EXPECT( | ||
| env.balance("bob") == | ||
| XRP(5200)); // 5100 (from last transaction) + 100 |
There was a problem hiding this comment.
@ximinez Can you please confirm if this new unit test which checks presence of cancel time and finish time combination is correct?
There was a problem hiding this comment.
considering there's a bunch of tests in this file that have almost same check (search for "Metadata to self" testcase for example), I'd say this seems correct
There was a problem hiding this comment.
Thanks for confirming.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5925 +/- ##
=======================================
Coverage 78.3% 78.3%
=======================================
Files 817 817
Lines 68978 68974 -4
Branches 8328 8324 -4
=======================================
- Hits 54010 54009 -1
+ Misses 14968 14965 -3
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
pratikmankawde
requested review from
a1q123456 and
vvysokikh1
and removed request for
ximinez
| env(escrow::finish("carol", "alice", seqFt), fee(150 * baseFee)); | ||
| BEAST_EXPECT( | ||
| env.balance("bob") == | ||
| XRP(5200)); // 5100 (from last transaction) + 100 |
There was a problem hiding this comment.
considering there's a bunch of tests in this file that have almost same check (search for "Metadata to self" testcase for example), I'd say this seems correct
pratikmankawde
added
the
Ready to merge
Amendments activated for more than 2 years can be retired. This change retires the fix1571 amendment.
bthomee
force-pushed
the
pratik/Retire_fix1571_amendment
branch
from
0128477 to
898bfa0
Compare
Amendments activated for more than 2 years can be retired. This change retires the fix1571 amendment. Co-authored-by: Bart Thomee <11445373+bthomee@users.noreply.github.com>
4 participants
High Level Overview of Change
This change retires the
fix1571amendment.Context of Change
Original amendment: https://xrpl.org/resources/known-amendments#fix1571
Amendments activated for more than 2 years can be retired.
Type of Change
.gitignore, formatting, dropping support for older tooling)