Skip to content

Conversation

@pratikmankawde
Copy link
Collaborator

High Level Overview of Change

This change retires the fix1543 amendment.

Context of Change

Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fix1543

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <[email protected]>
@pratikmankawde pratikmankawde requested a review from a team as a code owner October 23, 2025 13:26
@bthomee bthomee requested a review from a1q123456 October 23, 2025 13:36
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.5%. Comparing base (e192ffe) to head (d98a3f0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5926   +/-   ##
=======================================
  Coverage     78.5%   78.5%           
=======================================
  Files          817     817           
  Lines        69017   69007   -10     
  Branches      8276    8268    -8     
=======================================
+ Hits         54197   54200    +3     
+ Misses       14820   14807   -13     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/Escrow.cpp 99.2% <ø> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/Escrow.h 100.0% <ø> (ø)
src/xrpld/app/tx/detail/PayChan.cpp 96.3% <100.0%> (-0.1%) ⬇️
src/xrpld/app/tx/detail/PayChan.h 100.0% <ø> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pratikmankawde pratikmankawde added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 23, 2025
@bthomee bthomee removed the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 23, 2025
@bthomee
Copy link
Collaborator

bthomee commented Oct 23, 2025

@pratikmankawde there's a conflict - can you please resolve it first? I'd also like to get a sign-off from @a1q123456 before merging.

@pratikmankawde
Copy link
Collaborator Author

@pratikmankawde there's a conflict - can you please resolve it first? I'd also like to get a sign-off from @a1q123456 before merging.

Done

@bthomee
Copy link
Collaborator

bthomee commented Oct 24, 2025

@pratikmankawde There are some linking errors due to removing some of the getFlagsMask overrides - I'm sure it's an easy fix.

@bthomee bthomee requested a review from a1q123456 October 24, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants