Retire fix1578 amendment #5927
Open
Retire fix1578 amendment #5927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pratik Mankawde <[email protected]>
pratikmankawde
commented
Oct 23, 2025
| testAMM( | ||
| [&](AMM& ammAlice, Env& env) { | ||
| // Order that can't be filled | ||
| TER const killedCode{TER{tecKILLED}}; |
There was a problem hiding this comment.
Shall I get rid of this(and at other places) killedCode variable and use TER{tecKILLED} directly in its place?
a1q123456
approved these changes
Oct 24, 2025
pratikmankawde
added
the
Ready to merge
|
There's some conflicts. Can you fix them before adding the label please? |
a1q123456
removed
the
Ready to merge
Signed-off-by: Pratik Mankawde <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5927 +/- ##
=========================================
- Coverage 79.5% 78.5% -1.0%
=========================================
Files 817 817
Lines 72198 69014 -3184
Branches 8293 8272 -21
=========================================
- Hits 57392 54202 -3190
- Misses 14806 14812 +6
... and 489 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Pratik Mankawde <[email protected]>
pratikmankawde
requested review from
vvysokikh1
and removed request for
vlntb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change retires the
fix1578amendment.Context of Change
Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fix1578
Type of Change
.gitignore, formatting, dropping support for older tooling)