Retire fix1623 amendment #5928
Open
Retire fix1623 amendment #5928
+35
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pratik Mankawde <[email protected]>
pratikmankawde
requested review from
vvysokikh1
and removed request for
a team
pratikmankawde
commented
Oct 23, 2025
| return false; | ||
|
|
||
| TxType const tt{serializedTx->getTxnType()}; | ||
| // Transaction type should be ttPAYMENT, ttACCOUNT_DELETE or ttCHECK_CASH |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5928 +/- ##
=========================================
- Coverage 79.5% 78.5% -0.9%
=========================================
Files 817 817
Lines 72198 69001 -3197
Branches 8293 8269 -24
=========================================
- Hits 57389 54194 -3195
+ Misses 14809 14807 -2
... and 489 files with indirect coverage changes 🚀 New features to boost your workflow:
|
vvysokikh1
reviewed
Oct 23, 2025
Comment on lines
82
to
100
| bool | ||
| canHaveDeliveredAmountHelp( | ||
| GetFix1623Enabled const& getFix1623Enabled, | ||
| std::shared_ptr<STTx const> const& serializedTx, | ||
| TxMeta const& transactionMeta) | ||
| { | ||
| if (!serializedTx) | ||
| return false; | ||
|
|
||
| TxType const tt{serializedTx->getTxnType()}; | ||
| // Transaction type should be ttPAYMENT, ttACCOUNT_DELETE or ttCHECK_CASH | ||
| // and if the transaction failed nothing could have been delivered. | ||
| if ((tt == ttPAYMENT || tt == ttCHECK_CASH || tt == ttACCOUNT_DELETE) && | ||
| transactionMeta.getResultTER() == tesSUCCESS) | ||
| { | ||
| TxType const tt{serializedTx->getTxnType()}; | ||
| if (tt != ttPAYMENT && tt != ttCHECK_CASH && tt != ttACCOUNT_DELETE) | ||
| return false; | ||
|
|
||
| if (tt == ttCHECK_CASH && !getFix1623Enabled()) | ||
| return false; | ||
| return true; | ||
| } | ||
|
|
||
| // if the transaction failed nothing could have been delivered. | ||
| if (transactionMeta.getResultTER() != tesSUCCESS) | ||
| return false; | ||
|
|
||
| return true; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
you don't need this function anymore, move its functionality into canHaveDeliveredAmount
src/test/app/Check_test.cpp
Outdated
| testDeliveredAmountForCheckCashTnx(FeatureBitset features) | ||
| { | ||
| testcase("Fix1623 enable"); | ||
| testcase("DeliveredAmount For CheckCash Tnx"); |
There was a problem hiding this comment.
nit: did you mean Txn?
There was a problem hiding this comment.
Yeah, typo. Fixing.
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
pratikmankawde
requested review from
a1q123456 and
vlntb
and removed request for
vlntb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change retires the
fix1623amendment.Context of Change
Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fix1623
Type of Change
.gitignore, formatting, dropping support for older tooling)