Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5932 +/- ##
=========================================
- Coverage 78.5% 78.5% -0.0%
=========================================
Files 817 817
Lines 69017 69017
Branches 8275 8295 +20
=========================================
- Hits 54199 54175 -24
- Misses 14818 14842 +24 🚀 New features to boost your workflow:
|
92e9b32 to
47c1fe7
Compare
bthomee
reviewed
Oct 23, 2025
6dbc5de to
e0b9f86
Compare
bthomee
reviewed
Oct 24, 2025
Collaborator
bthomee
left a comment
There was a problem hiding this comment.
Looks good. There's still my other comment regarding parallelization - hopefully you can address that one too.
Collaborator
Author
Yes, I will, I've been busy with trying to make it work for Windows though - it's a bit tricky, since I don't know much about where build files end up there |
vvysokikh1
approved these changes
Oct 24, 2025
Collaborator
vvysokikh1
left a comment
There was a problem hiding this comment.
I approve cmake file change, as for workflows I don't really feel like I understand anything anyway :)
bthomee
reviewed
Oct 24, 2025
bthomee
approved these changes
Oct 24, 2025
2a44a0b to
f22f27a
Compare
352e430 to
10b8df0
Compare
bthomee
approved these changes
Oct 24, 2025
9 tasks
7f1c03a to
94d7f7e
Compare
bthomee
approved these changes
Oct 27, 2025
104c7af to
53e71ca
Compare
53e71ca to
7001067
Compare
7001067 to
f4d6f12
Compare
Bronek
pushed a commit
that referenced
this pull request
Oct 31, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
In #5817 only
rippledis uploaded as artifact, but there are multiple testing binaries to upload (and test).This approach:
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)