-
Couldn't load subscription status.
- Fork 1.6k
fix: Upload all test binaries #5932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5932 +/- ##
=======================================
Coverage 78.5% 78.5%
=======================================
Files 817 817
Lines 69017 69017
Branches 8276 8297 +21
=======================================
+ Hits 54197 54207 +10
+ Misses 14820 14810 -10 🚀 New features to boost your workflow:
|
92e9b32 to
47c1fe7
Compare
6dbc5de to
e0b9f86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There's still my other comment regarding parallelization - hopefully you can address that one too.
Yes, I will, I've been busy with trying to make it work for Windows though - it's a bit tricky, since I don't know much about where build files end up there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve cmake file change, as for workflows I don't really feel like I understand anything anyway :)
2a44a0b to
f22f27a
Compare
352e430 to
10b8df0
Compare
10b8df0 to
7f1c03a
Compare
…tiple testing binaries to upload (and test). This change: * Builds everything during build. * Puts them in the same dir (to make it easy to work with on both Windows and non-Windows). * Runs them in test workflow properly.
7f1c03a to
94d7f7e
Compare
High Level Overview of Change
In #5817 only
rippledis uploaded as artifact, but there are multiple testing binaries to upload (and test).This approach:
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)