Skip to content

Conversation

@Bronek
Copy link
Collaborator

@Bronek Bronek commented Oct 24, 2025

High Level Overview of Change

This change introduces amendment fixDirectoryLimit to remove directory pages limit

Context of Change

We found that the directory size limit is easier to hit than originally assumed, and there is no good reason to keep it since object reserve provides the necessary incentive to avoid creating unnecessary objects on the ledger.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@Bronek Bronek added this to the 3.0.0 milestone Oct 24, 2025
@Bronek Bronek requested a review from a team as a code owner October 24, 2025 10:23
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.5%. Comparing base (e192ffe) to head (e818332).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5935     +/-   ##
=========================================
- Coverage     78.5%   78.5%   -0.0%     
=========================================
  Files          817     817             
  Lines        69017   69021      +4     
  Branches      8276    8296     +20     
=========================================
- Hits         54197   54178     -19     
- Misses       14820   14843     +23     
Files with missing lines Coverage Δ
src/libxrpl/ledger/ApplyView.cpp 71.7% <100.0%> (+1.4%) ⬆️

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant