Skip to content

chore: Better pre-commit failure message#5940

Merged
bthomee merged 1 commit intoXRPLF:developfrom
mathbunnyru:better_pre_commit_fail
Oct 27, 2025
Merged

chore: Better pre-commit failure message#5940
bthomee merged 1 commit intoXRPLF:developfrom
mathbunnyru:better_pre_commit_fail

Conversation

@mathbunnyru
Copy link
Collaborator

High Level Overview of Change

Includes following change: XRPLF/actions#16

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru mathbunnyru requested a review from bthomee October 25, 2025 08:56
@mathbunnyru mathbunnyru added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Oct 25, 2025
@mathbunnyru mathbunnyru force-pushed the better_pre_commit_fail branch from 21d4434 to 4c7b7a2 Compare October 25, 2025 09:18
@bthomee
Copy link
Collaborator

bthomee commented Oct 26, 2025

We don't use ci: as prefix, so when merging I'll have to change your commit message anyway.

@mathbunnyru mathbunnyru force-pushed the better_pre_commit_fail branch from 4c7b7a2 to 3f3fb33 Compare October 27, 2025 13:38
@mathbunnyru mathbunnyru changed the title ci: Better pre-commit failure message chore: Better pre-commit failure message Oct 27, 2025
@mathbunnyru
Copy link
Collaborator Author

We don't use ci: as prefix, so when merging I'll have to change your commit message anyway.

Changed both PR title and commit message to chore

@mathbunnyru mathbunnyru added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 27, 2025
@bthomee bthomee added this pull request to the merge queue Oct 27, 2025
Merged via the queue into XRPLF:develop with commit 1845b1c Oct 27, 2025
7 checks passed
@Bronek Bronek mentioned this pull request Oct 31, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants