Skip to content

HTTP Bridge connect method #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
JoelBCarter wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

HTTP Bridge connect method #1218

JoelBCarter wants to merge 11 commits into from

Conversation

@JoelBCarter
Copy link
Member

@JoelBCarter JoelBCarter commented Jul 5, 2024

No description provided.

@JoelBCarter
Copy link
Member Author

JoelBCarter commented Jul 5, 2024 •
edited
Loading

Still some discovery here but it's illustrative of the issues i'm seeing with recursive resolve and needing to filter ourselves out of the publicChildren property. My main concern is "how could this happen" surrounding a module showing up in it's own public children. I caused a recursive resolve that never finished. I want to understand this so that we know how it got there to being with. For my purposes i was able to just .filer(m=>m.address===this.address) but I wanted to understand how it happened to see if:

  • I was just doing it wrong OR (more scary)
  • we're liable to have this happen in prod since i'm in the HttpBridgeBase code

When we get a chance to look into this deeper, we should see if we can better diagnose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JoelBCarter JoelBCarter

@arietrouw arietrouw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoelBCarter @arietrouw